fix(anvil): remove override for block.basefee when building transaction env #8517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #8516
when calling eth_estimateGas, the max_fee_per_gas parameter included in the tx ends up overwriting the block.basefee. This makes it harder to estimate gas for contracts that rely on the value of block.basefee.
Solution
remove the override for
block.basefee
fromfee_details.max_fee_per_gas
. If an override is necessary, maybe we can directly override theblockEnv.block
before passing tobuild_call_env
.explicitly disables basefee check when setting up the env for calls (used for eth_estimateGas, eth_createAccessList, eth_call, and tracing)