Skip to content

feat(cheatcodes): display cheatcode name in error message #8533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

DaniPopes
Copy link
Member

No description provided.

@DaniPopes DaniPopes force-pushed the dani/cheats-revert-with-name branch from 2b066bf to 0f57ab0 Compare July 26, 2024 15:10
Comment on lines -581 to +584
if actual_revert == expected_revert {
if actual_revert == expected_revert ||
(is_cheatcode && memchr::memmem::find(&actual_revert, expected_revert).is_some())
{
Copy link
Member Author

@DaniPopes DaniPopes Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattsse @klkvr FYI this changes _expectCheatcodeRevert to match on substring as well, to avoid changing all our tests; if you have better ideas LMK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems fine

@DaniPopes DaniPopes requested a review from mattsse July 29, 2024 12:17
@DaniPopes DaniPopes merged commit fdfaafd into master Jul 29, 2024
21 checks passed
@DaniPopes DaniPopes deleted the dani/cheats-revert-with-name branch July 29, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants