Open
Description
What's needed?
The resampling function documentation is not visible, as it is not included in the generated docs. It is also incomplete, as it doesn't mention the some details of what resampling function should expect as input samples.
frequenz-sdk-python/src/frequenz/sdk/timeseries/_resampling.py
Lines 75 to 100 in 6d106d1
Proposed solution
Expose the alias to the docs and clarify:
- It probably needs to use the term "relevant samples" (as the samples in the time windows as defined by
resampling_period
andmax_data_age_in_periods
) when saying which samples are passed. 1 - It needs to clarify that sample's values can only be numbers or if it can include
nan
orNone
(what about ìnf`?) - It needs to clarify that if there are no relevant samples, then the resampling function is not called at all (so resampling functions have guaranteed that
samples
can't be an empty collection).
Footnotes
-
The resampling helper class mentions:
All collected samples that are newer than
max(resampling_period, input_period).
max_data_age_in_periodsare considered *relevant* and are passed to the provided
resampling_functionwhen calling the
resample()` method.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
To do