Skip to content

[v2.9.0] Fish shell integration broken #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zx8 opened this issue May 1, 2025 · 3 comments
Closed

[v2.9.0] Fish shell integration broken #158

zx8 opened this issue May 1, 2025 · 3 comments
Assignees
@danielrobbins

Comments

@zx8
Copy link

zx8 commented May 1, 2025

v2.8.5

$ keychain --quiet --eval
set -e SSH_AUTH_SOCK; set -x -U SSH_AUTH_SOCK /var/folders/5z/ntc_xmz52zn0b5knq29h4n280000gn/T//ssh-ttCRfVAdmPNw/agent.1251;
set -e SSH_AGENT_PID; set -x -U SSH_AGENT_PID 1251;

v2.9.0

$ keychain --quiet --eval
SSH_AUTH_SOCK=/var/folders/5z/ntc_xmz52zn0b5knq29h4n280000gn/T//ssh-ttCRfVAdmPNw/agent.1251; export SSH_AUTH_SOCK;
SSH_AGENT_PID=1251; export SSH_AGENT_PID;
@danielrobbins
Copy link
Member

@zx8 will investigate -- thanks.

@danielrobbins danielrobbins self-assigned this May 1, 2025
@danielrobbins danielrobbins added the in progress this issue is actively being worked on label May 1, 2025
danielrobbins added a commit that referenced this issue May 1, 2025
@danielrobbins
Fix --eval for non-Bourne shells (#158)
1fda3ef
@danielrobbins
Copy link
Member

This is fixed in master; I'll roll out a new release later today to address this pretty serious bug. Thanks for reporting it.

@danielrobbins
Copy link
Member

This is now fixed in release 2.9.1.

@danielrobbins danielrobbins removed the in progress this issue is actively being worked on label May 1, 2025
@BrewTestBot BrewTestBot mentioned this issue May 1, 2025
Merged
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue May 3, 2025
security/keychain: update to 2.9.2
a28fda9 
# pkgsrc changes

* Project's Makefile is now bmake compatible. Use it to generate script and
  man page at build stage.
* Taking maintainership.

# upstream changes (since release 2.8.5)

## keychain 2.9.2 (2 May 2025)

This is primarily a bug fix release, but also introduces the new `--extended`
option -- see below:

* Deprecate `--confhost` option and replace with `--extended` option. The old
  `--confhost myhost` would now be `--extended host:myhost`. This also allows
  specifying SSH keys (`sshk:` prefix), GPG keys ( `gpgk:` prefix) and hosts
  (`host:` prefix) together without confusion.
* Well, I became intimately familiar with `IFS` the hard way. Fix 2.9.1 bug
  [#159](funtoo/keychain#159) by reworking IFS settings and
  adding proper documentation to the right places. This fixes the `--timeout` option
  and also now allows `--stop` to work properly which was broken.
* Improve `--agents` deprecation warning.
* Have keychain properly adopt a currently-running gpg-agent providing ssh-agent
  functionality when `--ssh-use-gpg` is specified.
* Explicitly clean up known-bad pidfiles during processing.
* Deprecate `--confhost` option and replace with new `--extended` option.
* Improve host-based key processing by using `ssh -G` to officially extract
  host-based keys.
* Make `Makefile` BSD-compatible.

## keychain 2.9.1 (1 May 2025)

This release fixes a major bug related to the `--eval` option with non-Bourne shells.

* Fix `--eval` option so it works with non-Bourne shells ([#158](funtoo/keychain#158)).
* Last-minute option change: replace `--ssh-wipe` and `--gpg-wipe` with `--wipe [ssh|gpg|all]`.
* Deprecate `--attempts` option which doesn't work with gpg-agent pinentry nor modern OpenSSH.
* More script rewriting -- default to IFS of newline in the script, totally rework SSH and GPG
  key adding code.
* Remove undocumented and likely unused `--` option.
* Script is now at a svelte 1049 lines of code.

## keychain 2.9.0 (30 Apr 2025)

These release notes contain a summary of all changes, including cumulative
changes in pre-releases:

* A new release after 8 years, with Daniel Robbins (script creator) returning as maintainer.
* 60% of the script has been rewritten, and is now compliant with
[ShellCheck](https://shellcheck.net).
* `--agents` and `--inherit` options have been deprecated to improve ease-of-use.
* `gpg-agent` no longer started by default -- only when a GPG key has been provided on the
  command-line. GnuPG 2.1+ supported.
* GnuPG pidfiles with `-gpg` extension are deprecated and no longer used.
* Better GnuPG integration: `gpg-agent` can be used for SSH key storage. This can be enabled
  by specifying one of the new `--ssh-allow-gpg` and `--ssh-spawn-gpg` options. Agent information
  for `gpg-agent`'s SSH socket will be stored in the regular pidfile for compatibility.
* Add `--ssh-rm`, `--ssh-wipe`, `--gpg-wipe` options for removing/wiping SSH and GPG keys. This addresses
  GitHub Issue [#153](funtoo/keychain#153).
* `--clear` option is now designed to be used for "initial clearing" of keys only.
* Many user interface output improvements, to provide additional detail.
* `--debug` option which can be used to troubleshoot issues with keychain.
* Manual page significantly improved: New section on invocation, as well as documentation of
  the startup and agent detection algorithm.
* Addition of `--ssh-agent-socket` option to manually specify desired path of the ssh-agent socket
  when starting.
* Addition of `--confallhosts` to load identity files for all hosts.
* Various bug fixes and improvements.
* Script size reduced from 1500 to 1133 lines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielrobbins danielrobbins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielrobbins @zx8