[24.2] Fix correctness of assertion validation in new linter. #19203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
force-pushed
the
fix_assertion_stuff
branch
from
2c66985 to
12b0881
Compare
jmchilton
force-pushed
the
fix_assertion_stuff
branch
from
12b0881 to
c172fff
Compare
|
I don't recall the difference between this and #19715 - but that one was merged so I will assume it was the right fix. I'm always so distracted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the YAML linters which were more strongly typed to validate the XML without a lot of processing - including no type conversion. Fixing this found some other problems also. Huge thanks to @bernt-matthias for reporting the issue - #19197 (comment).
This just fixes the correctness. We still probably need a way to improve the pydantic output for these validation errors.
How to test the changes?
(Select all options that apply)
License