Skip to content

[24.2] Allow access to published workflows #20091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Apr 25, 2025

Which is how it was before
2ff6aa5. Alternatively I could update all iwc workflows to also be accessible. I guess that would be more cosistent ...

The UI forces you to make the workflow accessible if you want to publish the workflow, which makes sense I guess.

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Which is how it was before
galaxyproject@2ff6aa5.
Alternatively I could update all iwc workflows to also be accessible.
I guess that would be more cosistent ...

The UI forces you to make the workflow accessible if you want to publish
the workflow, which makes sense I guess.
@mvdbeek
Copy link
Member Author

mvdbeek commented Apr 25, 2025

I have fixed up all of the iwc workflows. I guess it's unlikely that many people publish by API, so maybe the more solid thing to do is to make the PUT logic also toggle the importable flag (if not explicitly receiving a contradictory argument).

@mvdbeek mvdbeek closed this Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant