Skip to content

Fix a transiently failing API test. #20278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

jmchilton
Copy link
Member

'populated_state_message': 'Failed to fetch collection element(s):\n\n- Failed to fetch url https://raw.githubusercontent.com/galaxyproject/galaxy/dev/test-data/4.bed. HTTP Error 429: Too Many Requests',

I've stopped writing tests like this since the base64 URIs were implemented, not depending on an external service - even one as dependable as Github - provides greater test isolation and robustness and walks essentially all the same code paths in terms of Galaxy code we'd like to test. It should also be a bit faster.

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

``` 'populated_state_message': 'Failed to fetch collection element(s):\n\n- Failed to fetch url https://raw.githubusercontent.com/galaxyproject/galaxy/dev/test-data/4.bed. HTTP Error 429: Too Many Requests',```

I've stopped writing tests like this since the base64 URIs were implemented, not depending on an external service - even one as dependable as Github - provides greater test isolation and robustness and walks essentially all the same code paths in terms of Galaxy code we'd like to test.
@jmchilton jmchilton marked this pull request as ready for review May 18, 2025 13:10
@github-actions github-actions bot added this to the 25.1 milestone May 18, 2025
@mvdbeek mvdbeek merged commit 1cc16b6 into galaxyproject:dev May 19, 2025
55 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants