Skip to content

Changes to update_test_data testing mode #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

simonbray
Copy link
Member

I tried to improve the 'update test data' mode to make it a bit more user-friendly, see #1070. Ping @fubar2.

The currently behaviour is that the --update_test_data flag just causes the job_output_files dir to be copied back to the test dir. So the test results confusingly do not actually relate to the new updated data at all. Furthermore, if tests fail, the command needs to be rerun to check that they work with the new data.

New behaviour in this PR when the --update_test_data flag is used:

  • if tests fail, tests are automatically rerun after the test data has been updated, so that the results the user gets at the end relate to the new data, as expected. The user is informed that Test data were updated and tests were rerun.
  • if the tests pass, the test data are not updated and the user is explicitly informed that All x test(s) executed passed. Therefore, no test data were updated.

@bgruening
Copy link
Member

👍 I guess this will also be useful for automatic update PRs.

@fubar2
Copy link
Member

fubar2 commented Sep 16, 2020

Nice one, thanks @simonbray - that seems like a logical fix to me - will take a look shortly.

@jmchilton jmchilton merged commit 57e26f5 into galaxyproject:master Oct 2, 2020
@simonbray simonbray deleted the update_test_data branch December 2, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants