-
Notifications
You must be signed in to change notification settings - Fork 91
Bump galaxy-tool-util version in requirements #1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -7,7 +7,7 @@ cwltool>=1.0.20191225192155 | |||
docutils | |||
ephemeris>=0.10.3 | |||
galaxy-containers | |||
galaxy-tool-util>=20.9.0.dev2 | |||
galaxy-tool-util>=21.1.0.dev4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be an issue when updating the conda package for planemo, since this is a pre-release and there is no 21.1.x proper release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to get a conda package for this as well - if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but I didn't have the impression that having an up-to-date conda package was a high priority (the currently specified version is also a pre-release).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also wait for the official 21.01, it doesn't really bother me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the currently specified version is also a pre-release
Yes, but there is 20.9.x non pre-release package to satisfy the >=
requirement. Any way it's not an issue until this ends in a Planemo release and it's good to have this merged at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you have concerns, we could also create a dev branch and merge those PRs into the dev branch. I do think its worth to start working on new features during Galaxy release phase.
Specifically, so that that these two little PRs are available: galaxyproject/galaxy#10334, galaxyproject/galaxy#10886