-
Notifications
You must be signed in to change notification settings - Fork 91
Drop call to escape_non_unicode_symbols
#1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop call to escape_non_unicode_symbols
#1357
Conversation
which was removed from allure-python-commons in 2.13.0 .
Looking at the error message, I think the failing test is due to galaxyproject/galaxy#15497 , ping @nuwang . |
I'll go ahead and merge this anyway, since I think this break a lot of CI pipelines. |
Thanks @nsoranzo! |
@nsoranzo I just spotted this message. Is there an issue related to galaxyproject/galaxy#15497? |
Hi @nuwang , thanks for getting back! Yes, I think so, see this test run (line 2546): https://github.com/galaxyproject/planemo/actions/runs/4365276747/jobs/7633682776#step:8:2547
It seems the |
I think I see where the issue is originating from and adding file:// as a supported protocol should restore previous behaviour. I'll create a PR with a fix. |
That's great, thanks @nuwang ! |
which was removed from allure-python-commons in 2.13.0 .
Alternative to #1356 .