Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bgruening's original advice was to base this on whether
--galaxy_admin_key
was an actual admin key or not and just disable this functionality if not. My issue with this is that Planemo assumes a default admin key (that works withplanemo serve
defaults), so if the admin key is wrong and required I think it should be a hard failure not a silent behavior change. To put this another way, Planemo is tool development SDK, the correct assumption is that the target Galaxy is something it can just install tools into without worry - if that is not a correct assumption you need to change the behavior of Planemo and to do that the--no_shed_install
flag makes a lot of sense I think.I understand the critique that there are too many commands with too many options, and I have done things to make the default behaviors better (for instance none of the --conda_*** flags really need to be used for typical runs now). Rather than restricting functionality or making too clever assumptions I prefer the to go the route of documentation that focused on the actual commands to run and the relevant options for that use case. Therefore I've updated the documentation related to external Galaxy testing - and that doesn't cover twenty options - it covers only three - the most important three for external Galaxy testing including this new one.