Skip to content

GCR -> Artifact-Registry #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2024
Merged

GCR -> Artifact-Registry #293

merged 2 commits into from
Jan 26, 2024

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Jan 25, 2024

GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

  • europe-docker.pkg.dev/gardener-project/snapshots for snapshots
  • europe-docker.pkg.dev/gardener-project/releases for releases
  • europe-docker.pkg.dev/gardener-project/public for combined view of snapshots + releases

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr

Release note:

Change OCI Image Registry from GCR (`eu.gcr.io/gardener-project`) to Artifact-Registry (`europe-docker.pkg.dev/gardener-project/releases`). Users should update their references.

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Jan 25, 2024
@gardener-robot
Copy link

@ccwienk You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 25, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 25, 2024
@ccwienk
switch GCR -> Artifact-Registry
0538cd2 
GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

- europe-docker.pkg.dev/gardener-project/snapshots for snapshots
- europe-docker.pkg.dev/gardener-project/releases for releases
- europe-docker.pkg.dev/gardener-project/public for read-access to
  snapshots + releases

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gc
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 25, 2024
@ccwienk ccwienk requested a review from aaronfern January 25, 2024 09:14
@ccwienk
Copy link
Member Author

ccwienk commented Jan 25, 2024

Linter/Compiler error is likely not related to this change (I assume golang-version was changed).

rishabh-11
rishabh-11 approved these changes Jan 26, 2024
View reviewed changes
Copy link

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review labels Jan 26, 2024
@rishabh-11 rishabh-11 merged commit 0b4d5a7 into rel-v1.25 Jan 26, 2024
@rishabh-11 rishabh-11 deleted the gcr-to-ar-v1.25 branch January 26, 2024 11:45
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 26, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

@himanshu-kun himanshu-kun Awaiting requested review from himanshu-kun

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

@aaronfern aaronfern Awaiting requested review from aaronfern

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ccwienk @gardener-robot @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3