Upgrade Ginkgo v1 to v2 and Update Other Dependencies #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
size/xl
gardener-robot-ci-1
added
needs/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
|
/retest |
aaronfern
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
seshachalam-yv
force-pushed
the
upgrade-dependencies
branch
from
699640b to
3a473cd
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
seshachalam-yv
force-pushed
the
upgrade-dependencies
branch
from
8fcb345 to
e109eed
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
seshachalam-yv
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
aaronfern
reviewed
Aug 2, 2023
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
aaronfern
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
aaronfern
requested changes
Aug 10, 2023
gardener-robot-ci-2
added
reviewed/ok-to-test
aaronfern
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
aaronfern
approved these changes
Aug 10, 2023
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request aims to upgrade the Ginkgo from v1 to v2 and update other dependencies
Special notes for your reviewer:
In the process of these upgrades, several dependency conflicts were encountered with the
helm.sh/helm/v3library. The updated dependencies included an upgrade tohelm.sh/helm/v3to v3.5.0 which was found to be incompatible withk8s.io/client-gov0.20.6. An attempt to resolve this issue by upgradinghelm.sh/helm/v3to v3.12.0 did not resolve the issue due to a hard dependency ongoogle.golang.org/grpcv1.29.0 bygo.etcd.io/etcdv0.5.0-alpha.5.0.20200824191128-ae9734ed278b, whilehelm.sh/helm/v3v3.12.0 requiredgrpcv1.52.As a workaround for these dependency issues, the
k8s.io/helmlibrary (Helm V2) was used in place ofhelm.sh/helm/v3. This change should not impact the functionality of the integration tests as the Helm library is used only for deploying charts in these tests.It's important to note that
k8s.io/helmrepresents Helm V2, which is deprecated. Hence, this change is a temporary measure to allow for the necessary dependency updates. A more permanent solution that allows for the use of a supported Helm version should be considered for future updates.Release note: