Add unit tests for chunk deletion by garbage collector #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
reviewed/ok-to-test
…tter public for unit tests
anveshreddy18
force-pushed
the
tests/chunk-deletion
branch
from
f7acc50 to
a3a2053
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
seshachalam-yv
requested changes
Nov 27, 2023
There was a problem hiding this comment.
Thanks @anveshreddy18 for adding more tests
Please address my NIT comments
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
anveshreddy18
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
anveshreddy18
force-pushed
the
tests/chunk-deletion
branch
from
70bd063 to
57406ce
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
seshachalam-yv
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Thank you @anveshreddy18 for addressing for my review comments
/lgtm
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
ishan16696
reviewed
Nov 28, 2023
anveshreddy18
force-pushed
the
tests/chunk-deletion
branch
from
57406ce to
e9c4f13
Compare
anveshreddy18
force-pushed
the
tests/chunk-deletion
branch
from
e9c4f13 to
12ade26
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot
added
the
status/closed
renormalize
pushed a commit
to renormalize/etcd-backup-restore
that referenced
this pull request
Dec 18, 2023
* Add unit tests for chunk deletion in GC, Make prevSnapshot in snapshotter public for unit tests
shreyas-s-rao
pushed a commit
that referenced
this pull request
Dec 18, 2023
* Add unit tests for chunk deletion in GC, Make prevSnapshot in snapshotter public for unit tests Co-authored-by: Anvesh Reddy Pinnapureddy <[email protected]>
shreyas-s-rao
pushed a commit
to shreyas-s-rao/etcd-backup-restore
that referenced
this pull request
Jan 11, 2024
* Add unit tests for chunk deletion in GC, Make prevSnapshot in snapshotter public for unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds unit tests for chunk deletion by GC to make sure that GC only removes chunks and doesn't mess up with non-chunk objects in the store. And that the chunk deletion doesn't affect the general flow of operations in backup-restore.
Which issue(s) this PR fixes:
Fixes #684
Special notes for your reviewer:
Release note: