Skip to content

Use better naming for compaction jobs #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2023
Merged

Use better naming for compaction jobs #672

merged 2 commits into from
Sep 29, 2023

Conversation

abdasgupta
Copy link
Contributor

@abdasgupta abdasgupta commented Aug 21, 2023 •
edited by shreyas-s-rao
Loading

How to categorize this PR?

/area control-plane
/kind enhancement

What this PR does / why we need it:
Adds some improvements for betterment of compaction dashboard.

Which issue(s) this PR fixes:
Fixes #
#648

Special notes for your reviewer:
We need to address the issue gardener/gardener#8576 after this PR is merged

Release note:

Etcd snapshot compaction jobs will now be named `<etcd-name>-compactor` for better readability for human operators.

@abdasgupta abdasgupta requested a review from a team as a code owner August 21, 2023 07:36
@gardener-robot
Copy link

@abdasgupta Labels area/todo, kind/todo do not exist.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 21, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 21, 2023
@ashwani2k
Copy link
Collaborator

Please update the TODO's in description.

@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension labels Aug 21, 2023
@abdasgupta abdasgupta mentioned this pull request Aug 23, 2023
Merged
@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 23, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 23, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 23, 2023
@abdasgupta
Copy link
Contributor Author

/hold until gardener/etcd-backup-restore#660 is merged and new release of ETCD BR is cut

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Aug 23, 2023
@abdasgupta
Copy link
Contributor Author

cc @istvanballok

@abdasgupta
Copy link
Contributor Author

/retest

shreyas-s-rao
shreyas-s-rao requested changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdasgupta thanks for your PR. I have requested for a few changes. PTAL.

/cc @seshachalam-yv

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Aug 29, 2023
@abdasgupta
Copy link
Contributor Author

abdasgupta commented Sep 24, 2023 •
edited
Loading

I had an out-of-band discussion on this with @shreyas-s-rao and @seshachalam-yv and we came to conclusion that we need to take care of metricJobsCurrent with more accuracy. We also decided that a watch will be applied on compaction job status to accurately update the metricsjobcurrent when the compaction job actually succeeds or fails. So we decided that, instead of dealing metricJobsCurrent in this same PR which is only handling small improvements, I will raise another PR to handle metricJobsCurrent and update this PR only with the rest of the changes.

@abdasgupta abdasgupta mentioned this pull request Sep 28, 2023
Closed
@gardener-robot gardener-robot added size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Sep 28, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 28, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 28, 2023
@abdasgupta
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind

@abdasgupta
Copy link
Contributor Author

Raised #685 to take care of metricsjobcurrent metric updation correctly.

@abdasgupta
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind-alpha-features

@abdasgupta abdasgupta added this to the v0.20.0 milestone Sep 29, 2023
shreyas-s-rao
shreyas-s-rao approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdasgupta thanks for making the requested changes and removing the contentious code changes.
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Sep 29, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 29, 2023
@shreyas-s-rao shreyas-s-rao changed the title Adds some improvements in druid to enhance compaction dashboard. Use better naming for compaction jobs Sep 29, 2023
@shreyas-s-rao shreyas-s-rao merged commit a4229f6 into gardener:master Sep 29, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@istvanballok istvanballok istvanballok left review comments

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees

@abdasgupta abdasgupta

Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
8 participants
@abdasgupta @gardener-robot @ashwani2k @istvanballok @shreyas-s-rao @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3