Skip to content

Use flag from shoot spec instead of network extension to decide whether kube proxy is enabled/disabled. #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ScheererJ
Copy link
Member

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:
Use flag from shoot spec instead of network extension to decide whether kube proxy is enabled/disabled.

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
#56 is required to ensure that cilium is restarted properly when switching kube-proxy on/off.

Release note:

Removed kube-proxy disabled flag from extension config. Use the shoot spec (Shoot.Spec.Kubernetes.KubeProxy.Enabled) instead.

@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion area/networking Networking related kind/enhancement Enhancement, improvement, extension labels Jul 16, 2021
@gardener-robot
Copy link

@ScheererJ Thank you for your contribution.

@gardener-robot gardener-robot added needs/review size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2021
@DockToFuture DockToFuture marked this pull request as ready for review July 19, 2021 12:50
@DockToFuture DockToFuture requested review from a team as code owners July 19, 2021 12:50
Copy link
Member

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@DockToFuture DockToFuture merged commit c5b16aa into gardener:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Networking related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants