fix(gatsby): remove default noscript tag from html.js template

[gilbertoayala12]

Description

Removed banner saying This app works best with JavaScript enabled as requested.
This is no longer necessary because gatsby-plugin-offline was fixed to refresh when javascript was disabled plus lighthouse checks if any content is available.

Related Issues

Fixes #20021

[wardpeet]

Hey, thanks for your first contribution! 🎉 It seems like our tests are failing. To fix this, could you run yarn jest -u packages/gatsby/cache-dir/__tests__/static-entry.js in your terminal? This should change some of our snap files.

[gilbertoayala12]

@wardpeet Thank you! I ran the command you said, let's hope it passes the tests 😅

[pieh]

Thanks @gilbertoayala12! ❤️

Verified that lighthouse no longer list no content as an issue when JS is disabled with offline plugin installed, so this is good to go in!

[gatsbot]

Holy buckets, @gilbertoayala12 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

[nkhil]

@gilbertoayala @pieh @wardpeet I'm desperately trying to remove the This app works best with JavaScript enabled. message displayed when my Gatsby site is viewed with JS turned off.

I'm currently on Version 2.13.73of Gatsby. Will upgrading to the latest turn off the This app works best with JavaScript enabled. message?

I've tried a few other things, and haven't been successful.

[pieh]

@nkhil This changes was added in [email protected]. You can either upgrade or use guide in https://www.gatsbyjs.org/docs/custom-html/ to customize html template

[nkhil]

@pieh Thank you so much - that's worked!