Skip to content

fix(docs): brand names linux pages, add hint about rebuilding dependencies #20075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2019

Conversation

muescha
Copy link
Contributor

@muescha muescha commented Dec 11, 2019

Description

brand names:

  • curl -> cURL
  • Windows Store -> Microsoft Store
  • removed brackets

notes:

  • added a note from page Gatsby on Windows about rebuilding node modules and reinstall dependencies

Related Issues

PR #18263 chore(docs): Update the "Gatsby on Linux" page

open questions

should the section "Windows Subsystem for Linux" on Gatsby on Windows be with less content and point direct to the WSL section on "Gatsby on Linux"?

@muescha muescha requested a review from a team as a code owner December 11, 2019 15:15
@laurieontech
Copy link
Contributor

Thanks! All look like reasonable changes to me.

I'd agree with the Windows page. I'd say keep the WSL description and then send them to the instructions about WSL on the Linux page. Let me know if you want to do that or I can.

@laurieontech laurieontech merged commit 87f00a2 into gatsbyjs:master Dec 12, 2019
@muescha
Copy link
Contributor Author

muescha commented Dec 12, 2019

i am not so good writing new text in english - i would be happy if you can do that. thx

@laurieontech
Copy link
Contributor

Will do!

@muescha muescha deleted the muescha/docs/linux-pages branch December 12, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants