Skip to content

fix(gatsby-plugin-sharp): ignore incorrect duotone options #28999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 25, 2021
Merged

fix(gatsby-plugin-sharp): ignore incorrect duotone options #28999

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
15b0dc6
fix(gatsby-plugin-sharp): ignore incorrect duotone options
mxstbr Jan 12, 2021
177d409
Update packages/gatsby-plugin-sharp/src/index.js
mxstbr Jan 12, 2021
6422711
Update index.js
mxstbr Jan 12, 2021
11b3f73
add warning for invalid duotone options
Jan 25, 2021
be00844
Merge branch 'master' into gatsby-plugin-image/ignore-duotone
Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/gatsby-plugin-sharp/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,13 @@ async function generateBase64({ file, args = {}, reporter }) {

// duotone
if (options.duotone) {
pipeline = await duotone(options.duotone, options.toFormat, pipeline)
if (options.duotone.highlight && options.duotone.shadow) {
pipeline = await duotone(options.duotone, options.toFormat, pipeline)
} else {
reporter.warn(
`To use duotone for ${file.absolutPath}, please specify duotone.highlight and duotone.shadow as the two hex colors you want to use.`
)
}
}
let buffer
let info
Expand Down