Skip to content

Add support for memefish v0.6.1 AST types #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for memefish v0.6.1 AST types #107

wants to merge 2 commits into from

Conversation

utahta
Copy link

@utahta utahta commented Jun 13, 2025 •
edited
Loading

Summary

  • Updated memefish dependency from a commit-based version to v0.6.1
  • Updated Go version from 1.22.7 to 1.23.0
  • Updated go-cmp dependency from v0.6.0 to v0.7.0
  • Updated various other dependencies (k0kubun/pp, mattn/go-colorable)
  • Modified AST handling to support new memefish v0.6.1 structure:
    • Changed from .Name to .Idents[0].Name for table names
    • Updated column options handling for boolean fields
    • Modified default expression handling for generated columns
    • Updated function call handling to use new AST structure
    • Fixed example function names to follow Go naming conventions

Test plan

  • Verify all existing tests pass
  • Ensure database operations work correctly with new AST structure
  • Test table creation, indexing, and query operations

🤖 Generated with Claude Code

Fixed: #106

utahta and others added 2 commits June 13, 2025 09:18
@utahta @claude
Add support for memefish v0.6.1 AST types
fc7d83e 
Implement TupleStructLiteral and PathTableExpr support to resolve
unknown expression errors when using struct literals and INFORMATION_SCHEMA queries.

- Add TupleStructLiteral case in buildExpr for tuple-style struct syntax (1, 'foo')
- Add PathTableExpr case in buildQueryTable for schema-qualified table references
- Fix ArrayLiteral type propagation for nested TupleStructLiteral elements
- Update TypedStructLiteral validation for empty field cases
- Handle INFORMATION_SCHEMA path resolution in PathTableExpr
- Update AST structure handling for memefish v0.6.1 compatibility

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@utahta @claude
Update CircleCI Go version to 1.23
5f17b9e 
🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

github.com/cloudspannerecosystem/memefish version Update
1 participant
@utahta