PB-1009: simplify ApiGatewayMiddleware. #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per discussion in https://code.djangoproject.com/ticket/35971 Instead of copy/pasting `process_request` from the parent class, we can just drop the `Geoadmin-Username` header from `request.META` if `Geoadmin-Authenticated` is not true before calling `process_request` from the parent class.
adk-swisstopo
force-pushed
the
fix-PB-1009-apigw-header
branch
from
8df4201 to
220487f
Compare
adk-swisstopo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in https://code.djangoproject.com/ticket/35971
Instead of copy/pasting
process_requestfrom the parent class, we can just drop theGeoadmin-Usernameheader fromrequest.METAifGeoadmin-Authenticatedis not true before callingprocess_requestfrom the parent class.