PB-1434 : removal of the 'file' attribute & small file uploads from admin #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sami-nouidri-swisstopo
force-pushed
the
bug-PB-1434-asset-filename-fix
branch
from
8c75b88 to
fe1f235
Compare
added 18 commits
March 11, 2025 08:57
Please note the code is experimental as of now, it will be cleaned when it is made functional.
…ing tests After discussion, the direct upload view mechanism has been abandoned, in favor of adjusting the existing tests to not check for file content.
… if block LabelWidget has been simplified by removing the inheritance from TextInput and the unnecessary if condition. The text alignement has been corrected according to review comments.
sami-nouidri-swisstopo
force-pushed
the
bug-PB-1434-asset-filename-fix
branch
from
fe1f235 to
1a83a30
Compare
ltshb
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is a clone of this PR
Local tests with the docker image, as well as on Kubernetes show no sign of any of the previous problems. I'd like to merge it to see if it behaves accordingly on develop.latest