PB-1575: make test larger and more flexible. #568
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The remove_expired_items cronjob frequently runs out of memory in INT and PROD. As we are considering improvements, we need a way to easily test them and profile memory usage. This change adds a `remove_many_items` method that allows easily changing how many test items are considered. We also add two tests exercising that new method with 10 items and 10 assets each with and without dry run. From there we can easily get a very basic memory profile with something like this: ``` /bin/time -f %M pipenv run python3 app/manage.py test --verbosity=2 tests.tests_10.test_remove_expired_items ``` We will also probably tweak the exact number of items and assets later to match more realistic scenarios.
|
Superseded by #569 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remove_expired_items cronjob frequently runs out of memory in INT and PROD. As we are considering improvements, we need a way to easily test them and profile memory usage. This change adds a
remove_many_itemsmethod that allows easily changing how many test items are considered. We also add two tests exercising that new method with 10 items and 10 assets each with and without dry run.From there we can easily get a very basic memory profile with something like this:
We will also probably tweak the exact number of items and assets later to match more realistic scenarios.