-
Notifications
You must be signed in to change notification settings - Fork 15
Add WMTS and WMS layer components for 3D #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
v-if="layerConfig.type === LayerTypes.WMTS && !layerConfig.isExternal" | ||
:wmts-layer-config="layerConfig" | ||
:preview-year="previewYear" | ||
:projection="WEBMERCATOR" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't know if it would make sense to directly use the same logic as the one for OL, meaning :
:projection="layerConfig.isExternal ? WEBMERCATOR : LV95"
Some of our WMTS layers do not behave totally correctly when requested as EPSG:3857
or EPSG:4326
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cesium makes wrong requests when using LV95 for WMTS layer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can investigate and try to use WebMapServiceImageryProvider
instead of UrlTemplateImageryProvider
if LV95 required for WMTS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep mercator there then, it's something we should investigate if we want to have LV95 projection for 3D in the future (I doubt it's a good idea anyway, for 3D at least)
0903082
to
6fed90a
Compare
6fed90a
to
8f1e147
Compare
I added this to the doc
We can't use this mixin for GeoJSON and KML because it will be not imagery layers and zIndex, opacity, and URL will be handled differently. Maybe I will create one more mixin, more general |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! small issue with opacity to fix, and some unnecessary WMTS check in the utils function and we should be good to go!
b7a2867
to
c1f3b05
Compare
Test link