-
Notifications
You must be signed in to change notification settings - Fork 15
BGDIINF_SB-2980: add GeoJSON and KML layer components for 3d #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
da91163
to
7a2cc91
Compare
c460d16
to
fd77cbc
Compare
@pakb I added the KML layer component to this PR because it has related changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've some comment regarding the code, but my biggest concern is that it is not up to standard on the rendering side.
Here's what it looks in 2D
And here is the same place after a switch in 3D
I don't mind that labels are not rendered (although they should), but I will not accept that the numbers and "pills" are clipped by the terrain, we have to find a solution to this.
src/modules/map/components/cesium/utils/addPrimitiveLayer-mixins.js
Outdated
Show resolved
Hide resolved
src/modules/map/components/cesium/utils/addImageryLayer-mixins.js
Outdated
Show resolved
Hide resolved
@pakb I added |
efffbec
to
de5b0f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pakb I added
disableDepthTestDistance
and set it to 75km, please test. Should we keep it like this, adjust the distance, or remove it?
I think it's a good enough solution, you can go with this idea (just need to move the 75km into the config and explain what it is)
Thanks!
de5b0f4
to
f41d033
Compare
found some interesting discussion on the Cesium forum, with some solutions for Billboard and Label placement on top of terrain to avoid clipping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I found some interesting discussion on the Cesium forum, with some solutions regarding terrain clipping with Billboard and Labels, looking good!
Test link