-
Notifications
You must be signed in to change notification settings - Fork 15
BGDIINF_SB-3009: Create a floating tooltip for Cesium (+ BGDIINF_SB-2977 Create a profile position tracker for Cesium) #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5d9f1c
to
3035098
Compare
39a5b4a
to
54ae0ef
Compare
68b0aea
to
c5fac96
Compare
pakb
reviewed
Aug 18, 2023
vladyslav-tk
commented
Aug 18, 2023
vladyslav-tk
commented
Aug 18, 2023
this way it alleviate the issue raised by previous method here : CesiumGS/cesium#3247 We will have to make sure this works also with mobile
a3d517c
to
b2b0020
Compare
as with the sensitivity trick, it has a better rendering than mouse event (plus it works out of the box with the Cesium compass from geoblocks, mouse event didn't) Also adding a terrain tile loading detection, so that the tooltip position (height!) is updated as soon as a new terrain tile is loaded Adding back temp instances for Cesium calculation (small optimization)
b2b0020
to
c308012
Compare
pakb
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link