BGDIINF_SB-2890 : fix search tests #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
search now uses lat/lon from the backend, as there was some issue while using x/y with sr=2056. Might be a bug on the backend, but those coordinates were out of bound of LV95 when searching for addresses... Lat/Lon were correct, so I used them instead. Also adapting the fixture file to have only LV95 values (as that is what we are requesting from the backend, even though x/y are somewhat wrong on the real backend)
ltshb
requested changes
Oct 25, 2023
src/api/search.api.js
Outdated
| @@ -132,7 +132,7 @@ let cancelToken = null | |||
| * returned | |||
| * @returns {Promise<CombinedSearchResults>} | |||
| */ | |||
| async function search(queryString = '', lang = '', outputProjection) { | |||
| async function search(queryString = '', lang = '', outputProjection = DEFAULT_PROJECTION) { | |||
There was a problem hiding this comment.
I would not used any default projection in the api functions to avoid surprise when changing between projection.
There was a problem hiding this comment.
then I have to change the function signature, as it's the last param
ltshb
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search now uses lat/lon from the backend, as there was some issue while using x/y with sr=2056. Might be a bug on the backend, but those coordinates were out of bound of LV95 when searching for addresses... Lat/Lon were correct, so I used them instead. Also adapting the fixture file to have only LV95 values (as that is what we are requesting from the backend, even though x/y are somewhat wrong on the real backend)
Test link