BGDIINF_SB-2890: Fixed legacy parameters coordinates #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakb
approved these changes
Nov 1, 2023
The legacy parameter coordinates were not correctly reprojected. This was due to the fact that the reprojection happened in a loop several times instead of once. This has been solved by reorganizing a bit the code. Also corrected a test case that did not make sense with the new lv95 default projection. Now all legacyParamImport.cy.js test are passing.
ltshb
force-pushed
the
bug-BGDIINF_SB-2890-legacy-param-e2e
branch
from
e467b3c to
f2096b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy parameter coordinates were not correctly reprojected. This was
due to the fact that the reprojection happened in a loop several times instead
of once.
This has been solved by reorganizing a bit the code.
Also corrected a test case that did not make sense with the new lv95 default
projection. Now all legacyParamImport.cy.js test are passing.
Test link