Skip to content

BGDIINF_SB-3170: Fixed group of external layers attributions #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

ltshb
Copy link
Contributor

@ltshb ltshb commented Nov 6, 2023

When importing a group of external layers the attribution in the map footer was
missing and the disclaimer popup in the active layers was not displayed when clicking
on the disclaimer icon.

Test link

@github-actions github-actions bot added the bug label Nov 6, 2023
@ltshb ltshb force-pushed the bug-BGDIINF_SB-3170-import-attribution branch 2 times, most recently from fa77864 to 7d1f32f Compare November 6, 2023 14:00
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far so good! were you done with this PR, or is it here that you wanted to add what we discussed a couple hours ago?

@ltshb ltshb force-pushed the bug-BGDIINF_SB-3170-import-attribution branch 2 times, most recently from 15fab67 to 3d94239 Compare November 7, 2023 06:26
ltshb added 5 commits November 7, 2023 15:45
When importing a group of external layers the attribution in the map footer was
missing and the disclaimer popup in the active layers was not displayed when clicking
on the disclaimer icon.
The logging output of cypress has been improved which ease the debugging

Also fixed some sporadic timeout issues when running the test locally using
`npm run test:e2e` and `npm run test:e2e:desktop`
@ltshb ltshb force-pushed the bug-BGDIINF_SB-3170-import-attribution branch from 7e07358 to 08160b8 Compare November 7, 2023 14:45
@ltshb ltshb merged commit 7eb638f into develop Nov 7, 2023
@ltshb ltshb deleted the bug-BGDIINF_SB-3170-import-attribution branch November 7, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants