BGDIINF_SB-3193 : topics are now group of layers #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakb
force-pushed
the
feat_BGDIINF_SB-3193_geoadmin_group_of_layers
branch
from
899dac8 to
d5e6bf1
Compare
preparation work so that we can feed an external getCap parsing to the LayerCatalog component Removing all related TopicTree classes, and replacing them with the GeoAdminGroupOfLayers equivalent. Adapting the menu to use this new GeoAdminGroupOfLayers to build the topic tree. also fix : now implementing properly the opening of certain categories, if the backend tells to do so (switch to Aviation topic to have an example)
and fix an issue when default topic is set at startup with some catalog node that should be opened, the catalog wasn't opened correctly because of race condition between URL param parsing and topic loading (hence the move of isFirstSetTopic into the callback function)
pakb
force-pushed
the
feat_BGDIINF_SB-3193_geoadmin_group_of_layers
branch
from
d5e6bf1 to
e5fca8c
Compare
ltshb
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Looks good just a minor comment.
I also found a bug but apparently not related to this PR, see https://jira.swisstopo.ch/browse/BGDIINF_SB-3197 the bug is already present on the current develop branch, but when doing the rework we might first consider this strange bug, maybe there is a use case that we are not aware of ?
Comment on lines
60
to
67
| // reading the current topic at startup and opening any required category | ||
| onMounted(() => { | ||
| showChildren.value = openThemesIds.value.indexOf(item.getID()) !== -1 | ||
| }) | ||
| // reacting to topic changes (some categories might need some auto-opening) | ||
| watch(openThemesIds, (newValue) => { | ||
| showChildren.value = showChildren.value || newValue.indexOf(item.getID()) !== -1 | ||
| }) |
There was a problem hiding this comment.
We should keep the same organization as in Option API, meaning watch are before life-cycle hooks. I updated the readme about this see #534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preparation work so that we can feed an external getCap parsing to the LayerCatalog component
Removing all related TopicTree classes, and replacing them with the GeoAdminGroupOfLayers equivalent.
Adapting the menu to use this new GeoAdminGroupOfLayers to build the topic tree.
also fix : now implementing properly the opening of certain categories, if the backend tells to do so (switch to Aviation topic to have an example)
simplification of topics.cy.js and fix an issue when default topic is set at startup with some catalog node that should be opened, the catalog wasn't opened correctly because of race condition between URL param parsing and topic loading (hence the move of isFirstSetTopic into the callback function)
Test link