Skip to content

BGDIINF_SB-3180: External Layer refresh attributes on reload #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 22, 2023
Merged

BGDIINF_SB-3180: External Layer refresh attributes on reload #536

merged 6 commits into from
Nov 22, 2023

Conversation

ltshb
Copy link
Contributor

@ltshb ltshb commented Nov 16, 2023 •
edited
Loading

TODO in follow up PRs:

Test link

@ltshb ltshb added WIP and removed feature labels Nov 16, 2023
@ltshb ltshb mentioned this pull request Nov 17, 2023
Closed
@ltshb ltshb force-pushed the feat-BGDIINF_SB-3180-ext-layers branch from 637a252 to fa17109 Compare November 17, 2023 06:06
@ltshb ltshb force-pushed the feat-BGDIINF_SB-3180-ext-layers branch 3 times, most recently from ce4b32d to 9ec4379 Compare November 17, 2023 09:03
@ltshb ltshb removed the WIP label Nov 17, 2023
@ltshb ltshb requested a review from pakb November 17, 2023 09:04
@ltshb ltshb force-pushed the feat-BGDIINF_SB-3180-ext-layers branch from 9ec4379 to 4d29dee Compare November 17, 2023 09:23
@ltshb ltshb mentioned this pull request Nov 17, 2023
Merged
@ltshb ltshb force-pushed the feat-BGDIINF_SB-3180-ext-layers branch 2 times, most recently from a64fc68 to 92512a8 Compare November 17, 2023 09:48
pakb
pakb reviewed Nov 17, 2023
View reviewed changes
@ltshb ltshb force-pushed the feat-BGDIINF_SB-3180-ext-layers branch from 92512a8 to 05eb06c Compare November 17, 2023 10:46
@ltshb ltshb requested a review from pakb November 20, 2023 06:22
ltshb added 5 commits November 22, 2023 09:29
@ltshb
BGDIINF_SB-3180: External layers load attributes from capabilities on…
600bede 
… page reload

Now the external layers will automatically reload their Get Capabilities in order
to retrieved their attributes used for display upon page reload.

This also allow to save the minimal informations on the URL which is the
type, the base url and the layer ID.
@ltshb
BGDIINF_SB-3180: Minor changes required from code review
6054e91
@ltshb
BGDIINF_SB-3180: Renamed WMS and WMTS capabilities parser
2186007 
See code review comment.
@ltshb
BGDIINF_SB-3180: Fix error management and missing imports
781a085
@ltshb
BGDIINF_SB-3180: Avoid using the same ID on multiple dom elements
bbf8e0e
@ltshb ltshb force-pushed the feat-BGDIINF_SB-3180-ext-layers branch from 802bd82 to bbf8e0e Compare November 22, 2023 08:36
pakb
pakb approved these changes Nov 22, 2023
View reviewed changes
@ltshb ltshb merged commit 051e0bb into develop Nov 22, 2023
@ltshb ltshb deleted the feat-BGDIINF_SB-3180-ext-layers branch November 22, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakb pakb pakb approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltshb @pakb