Identification of KML layer features without the help of OpenLayers #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakb
force-pushed
the
feat_load_kml_data_async
branch
from
2432c97 to
70746e4
Compare
pakb
force-pushed
the
feat_identify_kml_feature_without_openlayers
branch
from
d281cf6 to
7ad2d39
Compare
pakb
force-pushed
the
feat_load_kml_data_async
branch
from
70746e4 to
07818d3
Compare
pakb
force-pushed
the
feat_identify_kml_feature_without_openlayers
branch
2 times, most recently
from
df4b1d6 to
ade36e9
Compare
ltshb
approved these changes
Dec 4, 2023
pakb
force-pushed
the
feat_load_kml_data_async
branch
2 times, most recently
from
b71fd71 to
49b911d
Compare
pakb
force-pushed
the
feat_identify_kml_feature_without_openlayers
branch
2 times, most recently
from
deeaff0 to
4415735
Compare
pakb
force-pushed
the
feat_identify_kml_feature_without_openlayers
branch
from
4415735 to
64571ad
Compare
so that it may work the same way when using Cesium I had to split the deserialize function of EditableFeature in two to achieve this, as the "old" deserialize wasn't receiving JSON data directly but the OpenLayers feature. So there's now a static function for when we have an OpenLayers' feature, and one (that is used by the aforementioned one) whose task is only to transforme a JSON object into the relevant EditableFeature instance.
pakb
force-pushed
the
feat_identify_kml_feature_without_openlayers
branch
from
64571ad to
55be236
Compare
as it is not synced with current OpenLayers code, and modifying a line/measure does not work anymore in some cases (we cannot drag/edit some points from the line)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that it may work the same way when using Cesium
I had to split the deserialize function of EditableFeature in two to achieve this, as the "old" deserialize wasn't receiving JSON data directly but the OpenLayers feature. So there's now a static function for when we have an OpenLayers' feature, and one (that is used by the aforementioned one) whose task is only to transforme a JSON object into the relevant EditableFeature instance.
Test link