Fix an issue when reloading a KML with adminId #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakb
force-pushed
the
bug_fix_reloading_kml_with_adminid
branch
from
9c9492c to
56c6691
Compare
ltshb
reviewed
Dec 4, 2023
ltshb
approved these changes
Dec 5, 2023
with the new KML data approach, and as we do not have the metadata of the layer at app startup, the URL param parser couldn't figure out if the drawing module should be shown or not (because of a protection against legacy KML layer being loaded at startup) So instead I've completely removed any adminId passthrough when parsing legacy KML layer, this way they are never given to the "modern" app, and will not be modified by web-mapviewer (that was the goal of this protection)
pakb
force-pushed
the
bug_fix_reloading_kml_with_adminid
branch
from
af24c24 to
8f4819c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the new KML data approach, and as we do not have the metadata of the layer at app startup, the URL param parser couldn't figure out if the drawing module should be shown or not (because of a protection against legacy KML layer being loaded at startup)
So instead I've completely removed any adminId passthrough when parsing legacy KML layer, this way they are never given to the "modern" app, and will not be modified by web-mapviewer (that was the goal of this protection)
Test link