Do not allow to push it.only() tests #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltshb
force-pushed
the
feat-no-it-only
branch
from
67df483 to
978692e
Compare
ltshb
force-pushed
the
feat-test-link
branch
from
e33f896 to
4bf3e52
Compare
ltshb
force-pushed
the
feat-no-it-only
branch
2 times, most recently
from
3e36bc1 to
3c4cca4
Compare
Now the external wms and wmts don't use anymore the version and layer name in url, so this make the e2e tests a bit more complex as we would need to intercept getCapabilities. So for the moment remove the version and name test.
Make sure the GetCap are loaded and that the layer is not anymore in loading state.
This ease the debugging in case of error.
Technically an external WMS/WMTS server can be served by several aliases (different hostnames or path). In this case if the user added the layer using the alias2 and alias1 was specified as getCap URL in the Capabilities answer of the server, the external layer could not be loaded properly because the alias2 was used in our URL param and alias1 was used to search for the active layer which results in active layer not found. To avoid such issue keep the original url as get cap url.
ltshb
force-pushed
the
feat-no-it-only
branch
from
3c4cca4 to
ac06c26
Compare
pakb
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link