Skip to content

BGDIINF_SB-3194: Added support for external layer legend #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

ltshb
Copy link
Contributor

@ltshb ltshb commented Dec 13, 2023

Now in the external layer catalogue the legends are also displayed if available.
Also adding the info button on the active layers for external layer.

Test link

@ltshb ltshb changed the base branch from develop to feat-no-it-only December 13, 2023 15:00
@ltshb ltshb requested a review from pakb December 13, 2023 15:00
Comment on lines 40 to 42
// const isSafeUrl = computed(() => {
// return new URL(layer.value.baseURL).hostname.includes('geo.admin.ch')
// })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to clean that

Comment on lines 69 to 71
<!-- eslint-disable vue/no-v-html-->
<!-- <div v-if="isSafeUrl" v-html="body"></div> -->
<!-- eslint-enable vue/no-v-html -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and that too

Base automatically changed from feat-no-it-only to develop December 14, 2023 07:12
@ltshb ltshb force-pushed the feat-BGDIINF_SB-3194-import-tool-ui-legend branch from 0133abf to be8052c Compare December 14, 2023 13:43
@ltshb ltshb requested a review from pakb December 14, 2023 13:43
@ltshb ltshb force-pushed the feat-BGDIINF_SB-3194-import-tool-ui-legend branch from be8052c to 60deaa6 Compare December 14, 2023 14:25
Now in the external layer catalogue the legends are also displayed if available.
Also adding the info button on the active layers for external layer.
@ltshb ltshb force-pushed the feat-BGDIINF_SB-3194-import-tool-ui-legend branch from 60deaa6 to b64b5f9 Compare December 14, 2023 19:00
@ltshb ltshb merged commit 5aa9ca9 into develop Dec 14, 2023
@ltshb ltshb deleted the feat-BGDIINF_SB-3194-import-tool-ui-legend branch December 14, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants