Skip to content

PB-110 : add print capabilities parsing and menu section #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

pakb
Copy link
Contributor

@pakb pakb commented Jan 12, 2024

Print layouts are loaded the first time the print menu section is opened

Test link

@pakb pakb requested a review from ltshb January 12, 2024 12:50
Copy link

cypress bot commented Jan 12, 2024

Passing run #223 ↗︎

0 161 19 0 Flakiness 0

Details:

PB-110 : add unit tests to cover print cap parsing and handling
Project: web-mapviewer Commit: 5bbbc5ed25
Status: Passed Duration: 04:32 💡
Started: Jan 15, 2024 1:06 PM Ended: Jan 15, 2024 1:10 PM

Review all test suite changes for PR #602 ↗︎

pakb added 2 commits January 15, 2024 08:08
Print layouts are loaded the first time the print menu section is opened
and add a bit of documentation to the menu tray tests (wasn't clear why we were waiting for 200ms each steps)
@pakb pakb force-pushed the feat_PB-110_parse_print_capabilities branch from 791a640 to 823e013 Compare January 15, 2024 07:20
Copy link
Contributor

@ltshb ltshb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good however there is some issues on the content of get capabilities, @hansmannj can you look at the get Capabilities of service print3, the name are prefixed with 1 and the A4 Protrait layout is twice and the second one don't have scale, see https://sys-map.dev.bgdi.ch/preview/feat_pb-110_parse_print_capabilities/index.html#/map?lang=fr&center=2660000,1190000&z=1&bgLayer=ch.swisstopo.pixelkarte-farbe&topic=ech&layers=ch.swisstopo.zeitreihen@year=1864,f;ch.bfs.gebaeude_wohnungs_register,f;ch.bav.haltestellen-oev,f;ch.swisstopo.swisstlm3d-wanderwege,f;ch.astra.wanderland-sperrungen_umleitungen,f

@hansmannj
Copy link
Member

Code looks good however there is some issues on the content of get capabilities, @hansmannj can you look at the get Capabilities of service print3, the name are prefixed with 1 and the A4 Protrait layout is twice and the second one don't have scale, see https://sys-map.dev.bgdi.ch/preview/feat_pb-110_parse_print_capabilities/index.html#/map?lang=fr&center=2660000,1190000&z=1&bgLayer=ch.swisstopo.pixelkarte-farbe&topic=ech&layers=ch.swisstopo.zeitreihen@year=1864,f;ch.bfs.gebaeude_wohnungs_register,f;ch.bav.haltestellen-oev,f;ch.swisstopo.swisstlm3d-wanderwege,f;ch.astra.wanderland-sperrungen_umleitungen,f

That's what @pakb has fixed here: https://github.com/geoadmin/service-print3/pull/18
Once the CI checks pass, we should merge that PR and deploy a new release at least on DEV, better on all stagings

@pakb pakb merged commit a30508a into develop Jan 15, 2024
@pakb pakb deleted the feat_PB-110_parse_print_capabilities branch January 15, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants