PB-114: Moved utils out of drawing modules #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Passing run #454 ↗︎
Details:
Review all test suite changes for PR #630 ↗︎ |
|||||||||||||||
ltshb
force-pushed
the
feat-PB-114-kml-4
branch
from
9c2df7a to
645b2dd
Compare
ltshb
force-pushed
the
feat-PB-114-kml-2
branch
from
8e8510a to
e13cf1b
Compare
ltshb
force-pushed
the
feat-PB-114-kml-4
branch
from
645b2dd to
9f95c9b
Compare
This function is used in several modules/utils
ltshb
force-pushed
the
feat-PB-114-kml-4
branch
from
9f95c9b to
c2a4ca9
Compare
pakb
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just about moving utils function out of drawing modules. Those function were used outside of the module so it was needed to avoid module interdependencies.
Test link