PB-111: Send print request #658

ismailsunni · 2024-02-26T06:47:26Z

Create print spec with geoblocks/mapfishprint
- handling grid
- handling legend
- handling qrcode url
- handling copyright with attributions
- handling WMTS with different projection (2056, 3857)
Send the spec with pooling (already in https://github.com/geoblocks/mapfishprint)
Cancel the printing
Still using a specific commit of geoblocks/mapfishprint, I will update it once the new version of the node package is released

cypress · 2024-02-26T06:54:59Z

Passing run #1142 ↗︎

0	172	22	0	0

Details:

PB-111: Upgrade to the latest geoblocks/mapfishprint to fix compatibility issue ...
Project: web-mapviewer	Commit: `d02e2d5b2d`
Status: Passed	Duration: 04:34 💡
Started: Mar 18, 2024 6:42 AM	Ended: Mar 18, 2024 6:47 AM

Review all test suite changes for PR #658 ↗︎

ismailsunni · 2024-02-26T09:04:11Z

~~ouch, wrong rebase.~~

ltshb · 2024-02-27T16:10:44Z

@ismailsunni I did a rework about the dispatcher see #659, please rebase your work and make sure that you follow the same syntax as in #659 about dispatching events.

ltshb · 2024-02-28T13:16:02Z

@ismailsunni the coordinates system printed on the map seems to be web mercator ? But the map is printed in LV95 am I right ?

ltshb · 2024-02-28T13:17:53Z

The legends with Journey through time - Maps is wrong on the print, this layer don't have a legend and no legend should be printed, now it print a grey square.

ltshb

@pakb I let you review the OpenLayersWMTSLayer.vue

src/api/qrcode.api.js

src/modules/map/components/openlayers/utils/print-area-renderer.composable.js

src/modules/map/components/openlayers/OpenLayersWMTSLayer.vue

pakb · 2024-03-05T13:04:40Z

src/modules/map/components/openlayers/OpenLayersWMTSLayer.vue

+        extent: extent,
+    })
+
+    const wmtsSource = new WMTSSource({


I think it would make sense to try to mimic what was done on the old viewer here, regarding params and values

see https://github.com/geoadmin/mf-geoadmin3/blob/6a7b99a2cc9980eec27b394ee709305a239549f1/src/components/map/LayersService.js#L521-L538

I tried to mimic all the params and values, beside the tileLoadFunction. I guess we can do it in other step/PR since it's not related to print directly. Is that ok @pakb ? It needs this kind of function https://github.com/geoadmin/mf-geoadmin3/blob/6a7b99a2cc9980eec27b394ee709305a239549f1/src/components/map/LayersService.js#L143, and it needs storage service (https://github.com/geoadmin/mf-geoadmin3/blob/develop/src/components/StorageService.js#L120) that I can't find it yet in the current mapviewer.

… true.

…tore.

async

…eSystem class.

…lity issue with OL 9.

github-actions bot added the feature label Feb 26, 2024

ismailsunni force-pushed the feat-PB-111-send-print-request branch from b919113 to f6fff86 Compare February 26, 2024 08:03

ismailsunni force-pushed the feat-PB-111-send-print-request branch from f6fff86 to f30e78e Compare February 26, 2024 09:55

ismailsunni requested review from pakb and ltshb February 27, 2024 05:06

ismailsunni marked this pull request as ready for review February 27, 2024 07:31

ismailsunni force-pushed the feat-PB-111-send-print-request branch 2 times, most recently from 91797ff to 2508d79 Compare February 28, 2024 08:44

ltshb reviewed Feb 28, 2024

View reviewed changes

pakb reviewed Mar 5, 2024

View reviewed changes

ismailsunni requested review from ltshb and pakb March 7, 2024 10:56

ltshb approved these changes Mar 7, 2024

View reviewed changes

ismailsunni force-pushed the feat-PB-111-send-print-request branch from 1673184 to 15535db Compare March 7, 2024 14:02

ismailsunni mentioned this pull request Mar 7, 2024

Add ol version 9 in peerDependencies. geoblocks/mapfishprint#22

Closed

ismailsunni force-pushed the feat-PB-111-send-print-request branch 3 times, most recently from b9fd9b7 to 8bafcf4 Compare March 18, 2024 05:36

ismailsunni added 7 commits March 18, 2024 13:39

PB-111: Add buttons to start and abort printing with the store.

d09fb13

PB-111: Add geoblocks/mapfishprint and create spec to do print request.

ed62d77

PB-111: Set some hardcoded values to make the printing works.

1532226

PB-111: Set printingStatus after print is finished.

1f8dff2

PB-111: Create QR Code URL from shortened URL

09cb59f

PB-111: Put some fake values for attributes.

07d3a5f

PB-111: Create WMTS Source not XYZ.

0140232

ismailsunni added 26 commits March 18, 2024 13:39

PB-111: Add store for graticule and legend.

fa0e74c

PB-111: Add grid to the map.

d8578a0

PB-111: Use different grid layer for different projection.

e42c6b8

PB-111: Add legend.

4ce79ef

PB-111: Handle different language and no legend.

22e8562

PB-111: Update geoblocks/mapfishprint to 0.2.3

6ff7e19

PB-111: Use latest commit from geoblocks/mapfishprint.

d80bb7f

PB-111: Add cancel print.

21a5b25

PB-111: Tidy up code.

fa68bd5

PB-111: Add copyright

82b2135

PB-111: show loading bar on printing process.

7edcc48

PB-111: Update geoblocks/mapfishprint and fix rebasing issues.

905a383

PB-111: Fix legends label.

9f9b511

PB-111: Add notes regarding layer without legend but hasLegend set to…

e351625

… true.

PB-111: Add JsDoc, encoded the URL, and use shortlink function, not s…

e975e77

…tore.

PB-111: Access directly the state of useGraticule and remove unneeded

98e6955

async

PB-111: Fix bug on wrong grid layer.

1e54ab8

PB-111: Use one dispatcher for print status and reference.

5f1b6bd

PB-111: Refactor printing error catchment.

5e5f7b3

PB-111: Update geoblocks/mapfishprint to latest released version.

69a730e

PB-111: Move getResoultions, getMatrixIds, and getExtent to Coordinat…

11eb316

…eSystem class.

PB-111: Add crossorigin and cacheSize to WMTSSource.

d92a5e7

PB-111: Add Time dimension on the WMTS Source.

20104e2

PB-111: Upgrade to geoblocks/mapfishprint that support OL 9.

635985a

PB-111: Fix layer.getID no longer exists

c3b948c

PB-111: Upgrade to the latest geoblocks/mapfishprint to fix compatibi…

d02e2d5

…lity issue with OL 9.

ismailsunni force-pushed the feat-PB-111-send-print-request branch from 8bafcf4 to d02e2d5 Compare March 18, 2024 06:39

ismailsunni merged commit dd4d3e5 into develop Mar 18, 2024
6 checks passed

ismailsunni deleted the feat-PB-111-send-print-request branch March 18, 2024 07:03

ismailsunni mentioned this pull request Mar 27, 2024

Move "print" job logic and management out of area composable #737

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PB-111: Send print request #658

PB-111: Send print request #658

ismailsunni commented Feb 26, 2024 •

edited

Loading

cypress bot commented Feb 26, 2024 •

edited

Loading

ismailsunni commented Feb 26, 2024 •

edited

Loading

ltshb commented Feb 27, 2024

ltshb commented Feb 28, 2024

ltshb commented Feb 28, 2024

ltshb left a comment

pakb Mar 5, 2024

ismailsunni Mar 7, 2024

PB-111: Send print request #658

PB-111: Send print request #658

Conversation

ismailsunni commented Feb 26, 2024 • edited Loading

cypress bot commented Feb 26, 2024 • edited Loading

Passing run #1142 ↗︎

Review all test suite changes for PR #658 ↗︎

ismailsunni commented Feb 26, 2024 • edited Loading

ltshb commented Feb 27, 2024

ltshb commented Feb 28, 2024

ltshb commented Feb 28, 2024

ltshb left a comment

Choose a reason for hiding this comment

pakb Mar 5, 2024

Choose a reason for hiding this comment

ismailsunni Mar 7, 2024

Choose a reason for hiding this comment

ismailsunni commented Feb 26, 2024 •

edited

Loading

cypress bot commented Feb 26, 2024 •

edited

Loading

ismailsunni commented Feb 26, 2024 •

edited

Loading