PB-322: Avoid reloading external layer upon browser history navigation #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #840 ↗︎
Details:
Review all test suite changes for PR #669 ↗︎ |
|||||||||||||||
ltshb
force-pushed
the
bug-external-layer
branch
2 times, most recently
from
8c761cb to
2bfc06e
Compare
pakb
approved these changes
Mar 4, 2024
When changing the config (opacity, visibility) of an external layer (KML, GPX, WMS or WMTS) and then use the browser history navigation to revert the changes, it triggered a reload of the layer and set its name back to the default until the layer has been reloaded. We can simply avoid this by updating the current layer object instead of creating a new one.
ltshb
force-pushed
the
bug-external-layer
branch
from
2bfc06e to
40cc125
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing the config (opacity, visibility) of an external layer (KML, GPX,
WMS or WMTS) and then use the browser history navigation to revert the changes,
it triggered a reload of the layer and set its name back to the default until
the layer has been reloaded.
We can simply avoid this by updating the current layer object instead of
creating a new one.
Test link