Fix layer drag and drop blocking transparency slider usage #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #892 ↗︎
Details:
Review all test suite changes for PR #676 ↗︎ |
|||||||||||||||
ltshb
reviewed
Mar 4, 2024
ltshb
approved these changes
Mar 4, 2024
pakb
force-pushed
the
bug_fix_layer_drag_drop_block_settings_events
branch
from
27344c1 to
ffc896a
Compare
I tested on my own device (iOS 17.3.1, Safari) it worked well, but this PR wasn't necessary for this kinds of devices. As we are using a delay on mobile/touch, this wasn't an issue there, only on desktop without the delay |
|
@pakb would be good to add an e2e test case for the the drag and drop of the opacity bar ? |
only react to drag and dropping when the title of the layer is handled, and not the settings area anymore
pakb
force-pushed
the
bug_fix_layer_drag_drop_block_settings_events
branch
from
ffc896a to
ac67d5b
Compare
Yes, but with all the pain I experienced trying to implement the "simple" drag and drop layer test, I'm not sure if I want to go back there 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only react to drag and dropping when the title of the layer is handled, and not the settings area anymore
Test link