PB-259, PB-329: Improve external WMS/WMTS layers startup performance #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #906 ↗︎
Details:
Review all test suite changes for PR #680 ↗︎ |
|||||||||||||||
ltshb
force-pushed
the
feat-PB-259-menu-module
branch
3 times, most recently
from
e89754c to
e9986a7
Compare
ltshb
force-pushed
the
feat-PB-259-update-layers
branch
from
aeec444 to
cfa87d3
Compare
ltshb
force-pushed
the
feat-PB-259-update-layers
branch
2 times, most recently
from
f78ebac to
9e8704e
Compare
ltshb
changed the title
ltshb
force-pushed
the
feat-PB-259-update-layers
branch
8 times, most recently
from
3033920 to
298b798
Compare
pakb
reviewed
Mar 5, 2024
pakb
approved these changes
Mar 6, 2024
ltshb
force-pushed
the
feat-PB-259-update-layers
branch
from
fbaad97 to
1e07eb6
Compare
Avoid loading multiple times the WMS/WMTS capabilities and avoid doing multiple dispatch. This reduce the startup time especially with multiple layers of the same source we can gain several seconds.
Make sure that that the layers coming from different urls and when adding more than one layer from a provider that the get capabilities is not called several times. Also make sure that the correct layer config is applied.
The layer id and also URL could contains specials characters ;,@| that are used by the parsing. So we need to encode them. They are encoded using percent encode. Other special characters are encoded by vue router.
The test now test the initial loading of several layers and make sure that the Get Capabilities are called only once
External layer that did not specified its opacity in URL could not be displayed as they default opacity was set to undefined. This has been broken with PR #677
The list of layer was inverted in the test.
ltshb
force-pushed
the
feat-PB-259-update-layers
branch
from
c7dbf63 to
874f4d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid loading multiple times the WMS/WMTS capabilities and avoid doing multiple
dispatch.
This reduce the startup time especially with multiple layers of the same source
we can gain several seconds.
Test link