PB-314: Moved the &embed to #/embed

[ltshb]

Now we use a new view for the embed instead of a query parameter.

Test link

[cypress]

Passing run #1003 ↗︎

0

169

22

0

0

Details:

PB-314: Minor code changes based on code review
Project: web-mapviewer	Commit: 066fe02515
Status: Passed	Duration: 04:38 💡
Started: Mar 8, 2024 4:09 PM	Ended: Mar 8, 2024 4:14 PM

Review all test suite changes for PR #694 ↗︎

[pakb]

At first glance, by playing with the test link :
great improvement! thanks

I saw that you filtered out some part of the UI that were forgotten (when they were added...) I think we should also remove the BG selector when in embedded (check an iframe example from mf-geoadmin3 here : https://codepen.io/geoadmin/pen/yOBzqM )

I'm totally OK not having the 3D button 👍

[pakb]

As a global comment on this file, I'm not sure we shouldn't make our view names constant in view/view.js and never use a hard-coded string. It might be more resilient to future renaming of the views

[ltshb]

At first glance, by playing with the test link : great improvement! thanks

I saw that you filtered out some part of the UI that were forgotten (when they were added...) I think we should also remove the BG selector when in embedded (check an iframe example from mf-geoadmin3 here : https://codepen.io/geoadmin/pen/yOBzqM )

I'm totally OK not having the 3D button 👍

The footer clean up and button will be done in separate PR/tickets