PB-317: Added basic toolbox to embed (zoom buttons) #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #1095 ↗︎
Details:
Review all test suite changes for PR #697 ↗︎ |
|||||||||||||||
ltshb
force-pushed
the
feat-PB-317-embed-zoom
branch
14 times, most recently
from
9c2b84a to
d64411f
Compare
ltshb
force-pushed
the
feat-PB-317-embed-zoom
branch
from
d64411f to
371cf29
Compare
The store crashed, because when toggling to 2d we need to set the camera position to null as in 2d we don't have a camera.
This is a preparation work to allow to add the basic map tools to the embed vue, therefore remove it from the menu module and put it to the map module. Those tools are anyway more some basic map tools that should be part of the map module, and we keep the menu module for more advanced stuff. Also made the map tool box with slot extensible.
…om windows.location To avoid issue parsing a second time the query from the url, use it from the vue router. Note that now we have more than one route and that the hash is not always #/map but can be something else like #/embed
The util getUrlQuery() was buggy has it worked only if the hash was #/map but now we have several views e.g. #/embed. Therefore remove this util and use the router instead.
This ease the debugging of flaky cypress drawing tests
Somehow this test failed when using the data-cy=map, the pointer event was never fired even though we waited for the pointer event to be set. It seems that using the ol-map instead solved the issue. NOTE: the issue was only on the CI !
- Added a way to wait for the map pointer event listener to be set - Added more logs to ease the debugging of flaky e2e tests - Fix drawing flaky test which used the cy.readStoreValue() with then(), in this case there is no retries and it might time to time failed, now we use window.its().should() which based on the cypress documentation should retry until the assertion is true.
ltshb
force-pushed
the
feat-PB-317-embed-zoom
branch
from
371cf29 to
f3b9cd8
Compare
ismailsunni
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link