PB-294: Avoid reloading the application when entering ENTER in import file #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasJoss
approved these changes
Mar 15, 2024
Passing run #1137 ↗︎
Details:
Review all test suite changes for PR #711 ↗︎ |
|||||||||||||||
… file In import file when entering enter with an invalid url field, it triggered a page reload. This was due to the fact that the `loadFile()` was triggered with an invalid url which triggered a fetch to the current host, reloading the app. Now we prevent calling loadFile() if the url is not valid.
An HTML form default behavior en keydow.enter is to submit the form which may trigger a page reload. Therefore remove the form as we don't really need it here and use `prevent` modifier for extra future security.
ltshb
force-pushed
the
bug-PB-294-import
branch
from
633701c to
51adc12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In import file when entering enter with an invalid url field, it triggered a
page reload. This was due to the fact that the
loadFile()was triggered withan invalid url which triggered a fetch to the current host, reloading the app.
Now we prevent calling loadFile() if the url is not valid.
Test link