PB-103 : arg constructor for SelectableLayers and children #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moving isDragged to EditableFeatures because it is used only in this context moving extent to base class, as we might want to use it across the board (also with drawing)
Passing run #1157 ↗︎
Details:
Review all test suite changes for PR #715 ↗︎ |
|||||||||||||||
ltshb
approved these changes
Mar 20, 2024
Comment on lines
+19
to
+21
| * @param {String | Number} featureData.id Unique identifier for this feature (unique in the | ||
| * context it comes from, not for the whole app) | ||
| * @param {Number[][]} featureData.coordinates Coordinates [[x,y],[x2.y2],...] or [x,y] if point |
There was a problem hiding this comment.
Nice way to document options I might do something similar in the layers store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving isDragged to EditableFeatures because it is used only in this context moving extent to base class, as we might want to use it across the board (also with drawing)
Test link