Skip to content

PB-103 : add parsing of getFeatureInfo capabilities for external layers #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2024
Merged

PB-103 : add parsing of getFeatureInfo capabilities for external layers #716

merged 3 commits into from
Mar 20, 2024

Conversation

pakb
Copy link
Contributor

@pakb pakb commented Mar 19, 2024 •
edited by github-actions bot
Loading

@cypress Cypress
Copy link

cypress bot commented Mar 19, 2024 •
edited
Loading

Passing run #1178 ↗︎

0 172 22 0 Flakiness 0

Details:

PR Review
Project: web-mapviewer Commit: d304320ed7
Status: Passed Duration: 04:45 💡
Started: Mar 20, 2024 8:21 AM Ended: Mar 20, 2024 8:26 AM

Review all test suite changes for PR #716 ↗︎

@pakb pakb requested review from ltshb, ltkum and LukasJoss March 19, 2024 07:38
@pakb pakb force-pushed the feat_PB-103_getFeatureInfo_cap_parsing branch from 9491760 to 0508ac6 Compare March 20, 2024 07:33
ltshb
ltshb approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@ltshb ltshb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good just minor comments.

You should also add some unitest for the new get feature info capabitlies

pakb added 3 commits March 20, 2024 09:18
@pakb
PB-103 : add parsing of getFeatureInfo capabilities for external layers
843a835
@pakb
Fix flaky issue with Unit test not having a default projection available
893d285
@pakb
PR Review
d304320 
Log if we default back to WGS84 with external layer
Add i81n key to a WMS getFeatureInfo parsing error (so that we may in the future display the error to the user)
Better handling of non existing getFeatureInfo formats
@pakb pakb force-pushed the feat_PB-103_getFeatureInfo_cap_parsing branch from 0508ac6 to d304320 Compare March 20, 2024 08:18
@pakb pakb merged commit bb820a6 into develop Mar 20, 2024
6 checks passed
@pakb pakb deleted the feat_PB-103_getFeatureInfo_cap_parsing branch March 20, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltshb ltshb ltshb approved these changes

@ltkum ltkum Awaiting requested review from ltkum

@LukasJoss LukasJoss Awaiting requested review from LukasJoss

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pakb @ltshb