PB-207 : GeoJSON data autoreload #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #1216 ↗︎
Details:
Review all test suite changes for PR #721 ↗︎ |
|||||||||||||||
pakb
force-pushed
the
feat_PB-207_geojson_data_autoreload
branch
2 times, most recently
from
b21282c to
c00a404
Compare
ltshb
requested changes
Mar 20, 2024
pakb
force-pushed
the
feat_PB-207_geojson_data_autoreload
branch
2 times, most recently
from
488e29e to
66e8bd6
Compare
when an updateDelay is set in the layer's config
when reprojecting GeoJSON data, select the CRS described in the GeoJSON (if any) directly in the reproject utils (we were parsing this CRS multiple times) ca8825
as some features from "Charging points for electrical cars" are balloon like, and are offset from the center of the feature coordinate (meaning we don't have a hit when clicking on the balloon) 23408d
pakb
force-pushed
the
feat_PB-207_geojson_data_autoreload
branch
from
66e8bd6 to
70de725
Compare
ltshb
approved these changes
Mar 21, 2024
Comment on lines
+40
to
+47
| const layerCopy = geoJsonLayer.clone() | ||
| layerCopy.geoJsonData = data | ||
| // we update through the action updateLayers, so that if multiple copies of the same GeoJSON layer are present, | ||
| // they will all be updated with the fresh data | ||
| store.dispatch('updateLayers', { | ||
| layers: [layerCopy], | ||
| ...dispatcher, | ||
| }) |
There was a problem hiding this comment.
Code is all good, but just as information, here instead of doing the clone you do
store.dispatch('updateLayers', {layers: [{id: geoJsonLayer.id, geoJsonData: data}], ...dispatcher})
But no need to change both are ok and good in my opinion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link