PB-103 : couple fixes and improvements #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #1192 ↗︎
Details:
Review all test suite changes for PR #722 ↗︎ |
|||||||||||||||
ltshb
reviewed
Mar 20, 2024
src/store/modules/layers.store.js
Outdated
Comment on lines
37
to
43
| let layer2Update = getActiveLayerById(state, layer.id) | ||
| if (layer2Update) { | ||
| Object.assign(layer2Update, layer) | ||
| if (layer instanceof AbstractLayer) { | ||
| state.activeLayers[state.activeLayers.indexOf(layer2Update)] = layer | ||
| } else { | ||
| Object.assign(layer2Update, layer) | ||
| } |
There was a problem hiding this comment.
It would be wise to first merge my PR about duplicate layers as this solve some issues here and the file has quite changed
pakb
force-pushed
the
feat_PB-103_couple_improvements
branch
from
352c30d to
c6df857
Compare
LayerFeature have a simple ID now, no more concat of the layer ID (was creating issues with external layers, as their IDs are pretty long and contain special characters) Feature title is used in the header, instead of relying on the layer title (the feature title is the layer name anyway, the way we built it) Auto transparency for WMS layer (based on the image format requested) and tiles/images aren't requested anymore if the viewport is completely outside the layer's extent (better for ExternalLayers) Pixel coordinate weren't correctly passed by the map-interaction composable
pakb
force-pushed
the
feat_PB-103_couple_improvements
branch
from
c6df857 to
025241e
Compare
ltshb
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LayerFeature have a simple ID now, no more concat of the layer ID (was creating issues with external layers, as their IDs are pretty long and contain special characters)
Feature title is used in the header, instead of relying on the layer title (the feature title is the layer name anyway, the way we built it)
Auto transparency for WMS layer (based on the image format requested) and tiles/images aren't requested anymore if the viewport is completely outside the layer's extent (better for ExternalLayers)
Pixel coordinate weren't correctly passed by the map-interaction composable
Test link