Skip to content

Use caret instead of plus/minus icons #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2024
Merged

Use caret instead of plus/minus icons #739

merged 2 commits into from
Mar 27, 2024

Conversation

ltshb
Copy link
Contributor

@ltshb ltshb commented Mar 27, 2024 •
edited by github-actions bot
Loading

Base automatically changed from bug-import-file-tool to develop March 27, 2024 06:57
@cypress Cypress
Copy link

cypress bot commented Mar 27, 2024 •
edited
Loading

Passing run #1353 ↗︎

0 166 22 0 Flakiness 0

Details:

Fixed pointer on swiss logo
Project: web-mapviewer Commit: 99af23046f
Status: Passed Duration: 04:29 💡
Started: Mar 27, 2024 11:46 AM Ended: Mar 27, 2024 11:51 AM

Review all test suite changes for PR #739 ↗︎

pakb
pakb reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@pakb pakb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this look more than the plus/minus one, I vote for it 👍

@rebert rebert self-requested a review March 27, 2024 07:22
@ismailsunni
Copy link
Contributor

I prefer the caret, looks more natural for me. Like a table of content. FYI, here is the comparison to make other easier to compare:
Caret:
image
Plus/Minus
image

@Angi-Kinas
Copy link
Contributor

I also like it better with the caret, since it does the same thing as the other open/close-sections.
I also noticed that the circle/border around the caret is gone when being clicked. I really like it! It looks much better, like with the up/down-arrows.

@ltshb ltshb force-pushed the feat-caret-instead-of-plus branch 2 times, most recently from 52c7a95 to 37b7004 Compare March 27, 2024 10:02
@ltshb ltshb marked this pull request as ready for review March 27, 2024 10:02
@ltshb ltshb requested a review from pakb March 27, 2024 10:02
@ltshb ltshb force-pushed the feat-caret-instead-of-plus branch from 37b7004 to dda209c Compare March 27, 2024 10:18
ltshb added 2 commits March 27, 2024 12:42
@ltshb
Use caret instead of plus/minus icon
f243d81 
Also remove the border of button which don't need a user feedback on click, like
for example the caret, checkbox and cog icon, as they are animated then don't
require any feedback.
@ltshb
Fixed pointer on swiss logo
99af230
@ltshb ltshb force-pushed the feat-caret-instead-of-plus branch from dda209c to 99af230 Compare March 27, 2024 11:42
@ltshb ltshb merged commit e889e0c into develop Mar 27, 2024
6 checks passed
@ltshb ltshb deleted the feat-caret-instead-of-plus branch March 27, 2024 12:05
@cypress cypress bot mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakb pakb pakb approved these changes

@rebert rebert Awaiting requested review from rebert

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ltshb @ismailsunni @Angi-Kinas @pakb