PB-361: Divers External Layers bug fixes #740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #1367 ↗︎
Details:
Review all test suite changes for PR #740 ↗︎ |
|||||||||||||||
pakb
approved these changes
Mar 27, 2024
ltshb
force-pushed
the
bug-PB-361-external-layer
branch
3 times, most recently
from
592ee3e to
bd53f43
Compare
Therefore made the parsing case insensitive.
The removed duplicates logic did not worked as expected and removed all projections from the list which resulted to fallback to WGS84.
Some provider are very slow, like for example the provider for jura.ch takes ~20-25s to download the get capabilities of 1.4MB !
Some provider like canton solothurn use KVP in WMTS instead of REST, those were broken because the get capabilities done by our open layer component did not added the KVP query parameters. Now we use the same code as used in the external catalogue parsing.
This avoid error logs and made the code complete, even though those projections are not used for WMTS layers.
Also removed possible race condition due to the .then() in cypress that don't do retries in opposite of .should()
To avoid to load the get capabilities for each layers, we now save the WMTS options in the layer object. Due to this we need to register the proj4 projection earlier than in the open layer map because the get capabilities are parsed during the startup before openlayer map is loaded.
ltshb
force-pushed
the
bug-PB-361-external-layer
branch
from
bd53f43 to
eb37dd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link